Add native build to CI and MUSL build #2490
Conversation
Quinn-With-Two-Ns
force-pushed
the
musl-build
branch
from
5c6c17b to
75b4c6e
Compare
Quinn-With-Two-Ns
changed the title
| @@ -188,3 +188,9 @@ jobs: | |||
|
|
|||
| - name: Run copyright and code format checks | |||
| run: ./gradlew --no-daemon checkLicenseMain checkLicenses spotlessCheck | |||
|
|
|||
| build_native_images: | |||
There was a problem hiding this comment.
Is it by intention that we are building native images for every CI run now or is this leftover from testing? If it is by intention, I would usually be concerned with unnecessarily using storage for all of these images, though I see we only retain for one day, but I wonder if it's even worth that vs just a workflow call option to not upload the artifacts.
There was a problem hiding this comment.
Yes, I do want to build as part of CI so we don't discover issue when trying to cut a release. I would be OK only doing the builds post merge or not including artifacts for CI
There was a problem hiding this comment.
Works for me, especially if it's concurrent and doesn't take longer than the existing jobs (doesn't seem to though that poor macos-arm one in last CI run took a really long time). I do think we should skip uploading the artifact though, but not a big deal.
There was a problem hiding this comment.
Are the test server artifacts on this PR's CI run much larger than what we've released in the past? For instance, Windows x64 on this PR's CI run is 62.4MB (exe inside about the same size), but the one at https://github.com/temporalio/sdk-java/releases is 18.4MB (exe inside about the same size). I wonder if it's due to Java upgrade or if we're inadvertently not trimming something anymore or what.
There was a problem hiding this comment.
hm good callout, not sure let me check
Add native build to CI and MUSL build
closes #2402